Conversation
Contributor
mxcl
commented
Dec 26, 2022
mxcl
commented
- Closes +bun.sh #1
- Using bun.sh binaries because we'll probs need to do the same for ziglang because ziglang OOMs during builds in CD
- However in general we are happy to use the binaries the project built—they know what they are doing and we should trust them in that.
- HOWEVER we should insist that they sign their binaries. Bun do not.
- ALSO really we should insist on signed sources, see comments in the YAML for more discussion
|
mxcl
force-pushed
the
bun
branch
2 times, most recently
from
5d0b6c6 to
9f68c76
Compare
* Closes #1 * Using bun.sh binaries because we'll probs need to do the same for ziglang because ziglang OOMs during builds in CD * However in general we are happy to use the binaries the project built—they know what they are doing and we should trust them in that. * HOWEVER we should insist that they sign their binaries. Bun do not. * ALSO really we should insist on signed sources, see comments in the YAML for more discussion * Not using profile versions as they are not documented and seemingly less portable (based on reading the installer)
Contributor
Author
|
well great, hangs in |
Contributor
Author
|
k it works fine locally on an intel Mac (macOS 12 though, not 11) |
Contributor
that is painful. limit to earlier release? or did they never support 11? |
Contributor
|
seems like there were hangs reported in darwin x86-64 in august, but they've minor bumped 3 versions since then: oven-sh/bun#1121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.